GoogleChromeLabs / chromeos_smart_card_connector

Smart Card Connector App for Chrome OS
https://chrome.google.com/webstore/detail/smart-card-connector/khpfeaanjngmcnplbdlpegiifgpfgdco
Apache License 2.0
133 stars 50 forks source link

Fix some undeclared JS deps #1138

Closed emaxx-google closed 3 months ago

emaxx-google commented 3 months ago

Add missing goog.require() declarations for symbols used in the file.

Sadly, such missing declarations aren't auto-detected by the Closure Compiler, but still lead to compilation errors when the inclusion order changes. This commit fixes some of manually spotted ones (detected via manual inspection and helper Shell scripts).

github-actions[bot] commented 3 months ago

Continuous Integration: All tests passed. C/C++ test coverage: 73.39% lines.