search

GoogleChromeLabs / chromeos_smart_card_connector

Smart Card Connector App for Chrome OS
https://chrome.google.com/webstore/detail/smart-card-connector/khpfeaanjngmcnplbdlpegiifgpfgdco
Apache License 2.0
133 stars 50 forks source link

Delete unneeded chrome.runtime.onConnect listener #1154

Closed emaxx-google closed 2 months ago

emaxx-google commented 2 months ago

The Smart Card Connector's background script doesn't currently need to listen for chrome.runtime.onConnect events.

In the past it was needed for wiring up PC/SC calls that happen within the application (namely, from the ReaderTracker class), but they were later migrated to directly send messages to the executable module's channel.

This cleanup is useful in the context of manifestv3 migration, since we'll need to open and listen for a bunch of message pipes in various places, and this old code would've thrown asserts for them.

github-actions[bot] commented 2 months ago

Continuous Integration: All tests passed. C/C++ test coverage: 73.35% lines.