search

GoogleChromeLabs / chromeos_smart_card_connector

Smart Card Connector App for Chrome OS
https://chrome.google.com/webstore/detail/smart-card-connector/khpfeaanjngmcnplbdlpegiifgpfgdco
Apache License 2.0
133 stars 50 forks source link

Refactor message awaiting #1166

Closed emaxx-google closed 1 month ago

emaxx-google commented 1 month ago

Create a small library function for for waiting on a specific incoming message. Cover it with unit tests.

This code will be reused for implementing the communication with popup dialogs in the manifest v3 mode.

github-actions[bot] commented 1 month ago

Continuous Integration: All tests passed. C/C++ test coverage: 73.52% lines.

github-actions[bot] commented 1 month ago

Continuous Integration: All tests passed. C/C++ test coverage: 73.58% lines.

emaxx-google commented 1 month ago

I realized I need to add await when calling assertRejects in tests, so that we don't leave the test body before the assertion has been checked.

github-actions[bot] commented 1 month ago

Continuous Integration: All tests passed. C/C++ test coverage: 73.52% lines.

github-actions[bot] commented 1 month ago

Continuous Integration: All tests passed. C/C++ test coverage: 73.58% lines.