GoogleChromeLabs / chromeos_smart_card_connector

Smart Card Connector App for Chrome OS
https://chrome.google.com/webstore/detail/smart-card-connector/khpfeaanjngmcnplbdlpegiifgpfgdco
Apache License 2.0
133 stars 50 forks source link

[mv3] Support popup windows - via message channels #1171

Closed emaxx-google closed 1 month ago

emaxx-google commented 1 month ago

This adds support of manifest v3 to the "popup-window" helpers. This is achieved by reimplementing the popup==>background page communication using message ports.

Previously, we used two other mechanisms for this communication:

Neither works in manifest v3 Extensions, hence this commit implements a new approach that should work in all build modes.

emaxx-google commented 1 month ago

@AleksMat This was already reviewed on #1167, but I screwed up merging and it ended up in a branch instead of main. Apologies :) Asking for a re-stamp.

github-actions[bot] commented 1 month ago

Continuous Integration: All tests passed. C/C++ test coverage: 73.59% lines.

emaxx-google commented 1 month ago

Thank you again :)