GoogleChromeLabs / chromium-bidi

Implementation of WebDriver BiDi for Chromium
https://googlechromelabs.github.io/chromium-bidi/
Apache License 2.0
85 stars 28 forks source link

feat!: respect `unhandledPromptBehavior` capability #2351

Closed sadym-chromium closed 1 week ago

sadym-chromium commented 1 week ago

BREAKING CHANGE: default behavior changed from ignore to dismiss.

Failing WPT tests should be addressed by https://github.com/web-platform-tests/wpt/pull/46895.

OrKoN commented 1 week ago

the commit is not conventional, although I am not sure it should be a breaking change since it is technically a fix

sadym-chromium commented 1 week ago

the commit is not conventional, although I am not sure it should be a breaking change since it is technically a fix

It's breaking in terms of some work would be required on Puppeteer side to keep API consistent, and some work on chromedriver is required as well.