search

GoogleChromeLabs / comlink

Comlink makes WebWorkers enjoyable.
Apache License 2.0
11k stars 382 forks source link

`requestResponseMessage` handlers optimization #650

Closed Tsury closed 6 months ago

Tsury commented 6 months ago

As per #647, I followed josephrocca's advice. Now there's one central function that assigns handlers from a map. I wasn't 100% sure where to add/remove the event listeners, open for suggestions.

My tests showed a ~20% performance increase in a mass-messages scenario, YMMV.

google-cla[bot] commented 6 months ago

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Tsury commented 6 months ago

I see someone already published a similar, more comprehensive PR.