search

GoogleChromeLabs / critters

🦔 A Webpack plugin to inline your critical CSS and lazy-load the rest.
https://npm.im/critters-webpack-plugin
Apache License 2.0
3.44k stars 108 forks source link

Warning when using :host-context that is subselects_1.subselects[name] is not a function #104

Closed starklord07 closed 1 week ago

starklord07 commented 2 years ago

I have updated my angular project to v13 and after getting this warning with :host-context selector that is subselects_1.subselects[name] is not a function.

I am using critters@0.0.14 as part of @angular-devkit/build-angular@13.1.2. I guess the issue is related to #90.

I am getting the following warning.

Generating index html...5 rules skipped due to selector errors: :host-context(.theme-themelight) .button.btn-primary -> subselects_1.subselects[name] is not a function ...

pszpor commented 2 years ago

I have the same issue @angular-devkit/build-angular@13.3.6 / critters@0.0.16 / css-select@4.3.0 effects with multiple working: subselects_1.subselects[name] is not a function

Dante1349 commented 2 years ago

same issue with "@angular-devkit/build-angular": "13.3.7", "critters": "0.0.16", is there a workaround how to fix it?

developit commented 2 years ago

Shouldn't be a workaround needed, since this is only a warning. It just means the generated critical CSS will not include the affected selector.

starklord07 commented 2 years ago

But is there any way to fix this warning ? I can recall, there was a similar issue #90 which was fixed.

PowerKiKi commented 2 years ago

This is very likely to have the same root cause as #103, and IMHO should be close as duplicate.

PowerKiKi commented 1 year ago

Solved by https://github.com/GoogleChromeLabs/critters/pull/124, which was released as 0.0.17.

@starklord07 , could you please close this issue ?

kara commented 1 week ago

Closing this issue because ownership of Critters has moved to the Nuxt team, who will be maintaining the project going forward. This repo is archived and won't receive any future updates.

If the issue is still relevant, please re-post it to the actively-maintained fork at https://github.com/danielroe/beasties.