Closed jllodra closed 2 years ago
I am upgrading from Angular 11 to 12 and I am getting these same errors that I did not have prior to upgrading. Here's an example of what I'm using in my scss:
@keyframes yellow_blink_animation { 0%,49% { fill: #00000000; } 50%,100% { fill: #ffcd05; } }
Keyframes are supposed to be skipped here, I assume that match may not be working. Is there anything funky prior to the keyframe rule in your generated CSS?
Keyframes are supposed to be skipped here, I assume that match may not be working. Is there anything funky prior to the keyframe rule in your generated CSS?
No, I removed everything but those lines. It is possible that Angular 12 is using an older version of critters (prior to the commit you have pointed). I can let you know if this is still happening or not when I update to Angular 13+.
Ran into this as well after updating to Angular 13. This change to the location @developit mentioned fixed it for me:
- rule.name !== 'keyframes'
+ rule.name !== 'keyframes' &&
+ rule.name !== '-webkit-keyframes'
Awesome, thanks @benz-netapp and @JessicaSachs! I've just merged the fix, and published it as critters@0.0.16 / critters-webpack-plugin@3.0.2.
This is happening in an angular12 project, which is using critters under the hood I assume.
In my styles.scss file I have:
If I remove this code, the warning disappears.
Probably the scss compiler is turning the
from
into a0%
, this is just a guess.