search

GoogleChromeLabs / css-triggers

A reference for the render impact of mutating CSS properties.
https://csstriggers.com/
Apache License 2.0
899 stars 70 forks source link

Add a legend #17

Closed zhouzi closed 8 years ago

zhouzi commented 8 years ago

The colors' meaning is not really obvious so this PR adds a legend that looks like this:

large small

I first used the same gray as the label's but the text looked lighter due to the colored rounds.

surma commented 8 years ago

Awesome! Thanks for your work, @Zhouzi! This LGTM, gonna wait for @paullewis to ACK this as well :)

oldergod commented 8 years ago

I know the new reaction feature on github was created for message like this to be avoided but I do think this simple PR would really help the usability of this awesome website.

surma commented 8 years ago

@Zhouzi Sorry for the delay on this. I just did cross-browser check and everything and I am about to merge this PR :tada: However, before I can do that, I need to ask you to sign Google’s CLA that we are allowed to use your contribution here :)

Please go here and let me know once you have signed the CLA.

zhouzi commented 8 years ago

It's already signed and the checks seem to be ok so I guess we're all good :)

surma commented 8 years ago

Hm.... I could have sworn I couldn’t find your signature earlier. All good now. Thanks again @Zhouzi :)

surma commented 8 years ago

It’s (a)liiiiiive 👾

zhouzi commented 8 years ago

Hell yeah, it is! 👽