search

GoogleChromeLabs / css-triggers

A reference for the render impact of mutating CSS properties.
https://csstriggers.com/
Apache License 2.0
902 stars 70 forks source link

Fix scrollbar's position and pointers-event #18

Closed oldergod closed 8 years ago

oldergod commented 8 years ago

fix #16

surma commented 8 years ago

Thanks @oldergod for the awesome work.

There’s only one issue (that I ran into as well while trying to whip up a quick fix) when the browser window gets small:

screenshot 2016-05-09 12 49 33

Do you have an idea on how to fix this?

oldergod commented 8 years ago

@surma I cannot repro this. I tried in Chrome/Firefox(Ubuntu), Safari/Chrome(iPhone6S), Chrome(Nexus5) Here is what I see in Chrome on Ubuntu:

image

Am I missing something? Since I see a ruler, I guess you are using Chrome? on Mac? I'll be able to try this on Mac at the end of the week.

oldergod commented 8 years ago

@surma I could reproduce what you saw this way:

  1. toggle device mode
  2. set device type to Desktop
  3. refresh and scroll a bit till header expands
  4. set device type to Mobile

But the werid thing is : if I start with a device type set to Mobile, I cannot reproduce it. I tested on iPhone6s and Nexus5 without problem so I would rather think it is a chrome thing?

css_triggers_test_scrollbar

surma commented 8 years ago

Alright, if it’s a chrome-thing only, then feel free to ignore it.

Is this ready to merge in your opinion?

oldergod commented 8 years ago

IMO it is, yes. If ever a bug were to show up, I would promptly fix it anyway!

surma commented 8 years ago

@oldergod Forgive me for how long it took me to get back to you! I/O and the subsequent jetlag knocked me out ;)

Finally gave this the last test run. LGTM. Merged. Awesome 🎉