Remove message show when we close filter

GoogleChromeLabs / css-triggers

A reference for the render impact of mutating CSS properties.

https://csstriggers.com/

Apache License 2.0

902 stars 70 forks source link

Remove message show when we close filter #32

Closed tarungarg546 closed 8 years ago

tarungarg546 commented 8 years ago

This commit fixes an unreported issue that if we open up filter and then closes it without any value supplied or with any value supplied then there is always a message in bottom that

There is no property containing ""

which is un-neccessary and un-wanted so by this fix when checking on visibleCount in changeOnFilter we are also checking on if filterValue is "" or empty then hide the message.

GIF is better than thousand words so...

Before

After

surma commented 8 years ago

I think this is safe to merge ;) Thanks, @tarungarg546!