GoogleChromeLabs / estimator.dev

🧮 Calculate the size and performance impact of switching to modern JavaScript syntax.
https://estimator.dev
Apache License 2.0
665 stars 23 forks source link

Disable autocorrect on URL input field #9

Closed morellodev closed 3 years ago

morellodev commented 3 years ago

This PR fixes #8 @developit

google-cla[bot] commented 3 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

morellodev commented 3 years ago

@googlebot I signed it!

Dennis Morello Front-End Engineer

W: https://morello.dev E: dennismorello@gmail.com Il 11 dic 2020, 12:49 +0100, google-cla[bot] notifications@github.com, ha scritto:

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). đź“ť Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it. What to do if you already signed the CLA Individual signers

• It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

• Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version). • The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits. • The email used to register you as an authorized contributor must also be attached to your GitHub account.

ℹ️ Googlers: Go here for more info. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or unsubscribe.

morellodev commented 3 years ago

Sorry for the blank lines, I disabled auto-format on save on my IDE but they still were added 🤔 Anyway, actually they make the code more readable – you could add ESLint and Prettier to this project to standardize linting and formatting