Closed jerosoler closed 3 years ago
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
:memo: Please visit https://cla.developers.google.com/ to sign.
Once you've signed (or fixed any issues), please reply here with @googlebot I signed it!
and we'll verify it.
ℹ️ Googlers: Go here for more info.
@googlebot I signed it!
Thanks for this PR! I love this demo! A few questions:
--cornerbox-line
is at 0. Is it possible to take this full off-canvas?--cornerbox-line
because I think this is a neat effect that can animate in--cornerbox-lenght
has a typo, but might also make more sense to be called the --cornerbox-width
instead. Similarly, I might rename --cornerbox-line
to be --cornerbox-length
, because it feels more descriptive Hello @una
Thanks a lot! I like that you like it!
I have uploaded the corrections you indicate. You're right ;) Good work!
Nice one!
Demo: https://jerosoler.github.io/cornerbox/