GoogleChromeLabs / jsvu

JavaScript (engine) Version Updater
https://mths.be/jsvu
Apache License 2.0
1.89k stars 90 forks source link

Missing files when try to update V8 and Hermes #91

Closed igor-simoes closed 4 years ago

igor-simoes commented 4 years ago

Hello, I'm trying to update my engines via jsvu. The engines Chakra, SpiderMonkey and JavaScriptCore works as expected, but V8 throws a Promisse error when try to rename a file that does not exists. The zip file extracted does not contains the natives_blob.bin, only the snapshot_blob.bin and icudtl.dat.

✔ Found latest V8 version: v8.5.74.
✔ URL: https://storage.googleapis.com/chromium-v8/official/canary/v8-linux64-rel-8.5.74.zip
✔ Download completed.
❯ Extracting…
Installing library to ~/.jsvu/engines/v8/icudtl.dat…
Installing library to ~/.jsvu/engines/v8/natives_blob.bin…
(node:6521) UnhandledPromiseRejectionWarning: Error: ENOENT: no such file or directory, rename '/tmp/fcb5484d35ac7dbe3cc56f9b19b5aac7/natives_blob.bin' -> '/home/isol2/.jsvu/engines/v8/natives_blob.bin'
    at Object.renameSync (fs.js:593:3)
    at tryRenameSync (/usr/lib/node_modules/jsvu/node_modules/fs-extra/lib/move-sync/index.js:27:19)
    at Object.moveSync (/usr/lib/node_modules/jsvu/node_modules/fs-extra/lib/move-sync/index.js:22:3)
    at Installer.installLibrary (/usr/lib/node_modules/jsvu/shared/installer.js:54:7)
    at Promise (/usr/lib/node_modules/jsvu/engines/v8/extract.js:35:13)
(node:6521) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). (rejection id: 1)
(node:6521) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.

I tried to install Hermes too and another error was thrown.

(node:6540) UnhandledPromiseRejectionWarning: Error: Cannot find module './engines/hermes/index.js'
    at Function.Module._resolveFilename (internal/modules/cjs/loader.js:582:15)
    at Function.Module._load (internal/modules/cjs/loader.js:508:25)
    at Module.require (internal/modules/cjs/loader.js:637:17)
    at require (internal/modules/cjs/helpers.js:22:18)
    at /usr/lib/node_modules/jsvu/cli.js:187:7
    at process._tickCallback (internal/process/next_tick.js:68:7)
(node:6540) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). (rejection id: 1)
(node:6540) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.
igor-simoes commented 4 years ago

Closing this issue, my jsvu version was outdated.