GoogleChromeLabs / link-to-text-fragment

Browser extension that allows for linking to arbitrary text fragments.
https://chrome.google.com/webstore/detail/link-to-text-fragment/pbcodcjpfjdpcineamnnmbkkmkdpajjg
Apache License 2.0
412 stars 33 forks source link

Control+Shift+L clashes with Google Docs shortcut #15

Closed FenyLabs closed 4 years ago

FenyLabs commented 4 years ago

When I do ctrl+shift+l to left align on Google Docs, the popup appears telling me I haven't selected anything to copy the link to. This also prevents the shortcut from working (the text is still center aligned). I am on a Chromebook, if that has anything to do with the shortcut not working. I'm a little disappointed that 3 Google products clash and don't work together properly.

tomayac commented 4 years ago

You can customize the extension’s shortcut by pasting chrome://extensions/shortcuts into the URL bar. You can then choose something that doesn’t clash with other apps.

samdutton commented 4 years ago

Might be worth adding this to the extension overview — I had the same problem.

tomayac commented 4 years ago

I'm all open to a new shortcut default. Any ideas? My idea was to have something with an 'L' for "Link to Text Fragment".

samdutton commented 4 years ago

Maybe no default shortcut, but explain how to add one?

(I just right-click — might be worth making that method really clear.)

On Fri, 16 Oct 2020 at 12:33, Thomas Steiner notifications@github.com wrote:

Reopened #15 https://github.com/GoogleChromeLabs/link-to-text-fragment/issues/15.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/GoogleChromeLabs/link-to-text-fragment/issues/15#event-3885930137, or unsubscribe https://github.com/notifications/unsubscribe-auth/AABSDKUB25HWR4FHGFXFI4DSLAVSNANCNFSM4SBGNZQA .

Titan21 commented 4 years ago

Hi, I also just came here to complain about the clashing shortcut, and the inability to change it. I never knew there's a way to configure Shortcuts to Chrome Extensions (like you pointed out above at chrome://extensions/shortcuts ) Unfortunately I'd say don't configure a default shortcut unless there's a way in the Extension options image to change / disable the shortcut or point to chrome://extensions/shortcuts

tomayac commented 4 years ago

Thanks for the input. I've removed the suggested default hotkey, which means there won't be a clash anymore for all users, and power users can still set their own preferred hotkey. The new version will be released in the next days.

SmartManoj commented 4 years ago

I'm all open to a new shortcut default. Any ideas? My idea was to have something with an 'L' for "Link to Text Fragment".

Ctrl+Shift+F

SmartManoj commented 4 years ago

Thanks for the input. I've removed the suggested default hotkey, which means there won't be a clash anymore for all users, and power users can still set their own preferred hotkey. The new version will be released in the next days.

Need to update Pro Tip

tomayac commented 4 years ago

Thank you for the reminder, I have updated the pro-tip and the change should go live once the new description gets approved.