GoogleChromeLabs / link-to-text-fragment

Browser extension that allows for linking to arbitrary text fragments.
https://chrome.google.com/webstore/detail/link-to-text-fragment/pbcodcjpfjdpcineamnnmbkkmkdpajjg
Apache License 2.0
412 stars 33 forks source link

Chrome Extension is disabled when running CCleaner Custom Clean #44

Closed Mike-B2021 closed 3 years ago

Mike-B2021 commented 3 years ago

As per title - all the information is here

https://community.ccleaner.com/topic/61192-chrome-extension-is-disabled-when-running-ccleaner-custom-clean/ (Password not required to read)

Please contact me for further information if needed. Tnx

tomayac commented 3 years ago

Thanks for the note. Nothing actionable from a Chrome browser point of view, though.

Mike-B2021 commented 3 years ago

As per my original post with the link to CCleaner forum, it has now been shown that the issue only occurs with a particular CCleaner setting. It would be good if the Dev responsible for the Extension would investigate as CCleaner have said it shouldn't work that way.

tomayac commented 3 years ago

Can you point out the actionable step from the forum post?

Mike-B2021 commented 3 years ago

https://community.ccleaner.com/topic/61192-chrome-extension-is-disabled-when-running-ccleaner-custom-clean/?do=findComment&comment=331963

Where it says:

_The session information seems entirely the wrong place to be saving a context menu setting, (you would have thought that anything extension related should be saved in the 'extensions' directory: C:\Users[loginname]\AppData\Local\Google\Chrome\User Data\Default\Extensions), But I can only think that the developer of the extension is doing it that way for some reason. Maybe he can't get it to work any other way in Chrome? (or maybe he has not realised it's being saved in the wrong place?) Maybe Chrome has changed where things should be stored, but that extension hasn't been changed yet? Chrome (and Firefox) do keep changing where things are or should be stored.

But...I strongly advise reading the whole thread so as to see the symptom and how I tested to show it only occurs with the CCleaner "Sessions" setting activated.

tomayac commented 3 years ago

The context menu code is https://github.com/GoogleChromeLabs/link-to-text-fragment/blob/88a43c218884431edc0146c751017ada5deecf34/background_script.js#L83-L97.

Mike-B2021 commented 3 years ago

@tomayac Thanks but that is of no use to me (the end user) - it needs to be alerted to CCleaner. I'll update THAT thread now.

tomayac commented 3 years ago

I am not in a position to judge external software, but as a user I have seen CCleaner ads in spurious sites and personally wouldn't feel comfortable installing it on my own computer. The recommended way to "clean" your Chrome profile is outlined in this help article.

Mike-B2021 commented 3 years ago

My experience of CCleaner is altogether positive. It does what the help article does in a somewhat more elegant and less time-consuming way. The whole point of this issue is that an extension is (apparently) incorrectly coded so as to negatively interact with CCleaner and cause itself to be disabled! Look at the screenshots (also attached to this message) in the CCleaner thread where the extension doesn't even appear in the CCleaner list, whereas all the other extensions do so appear.

And yet, running CCleaner with Sessions enabled, disables JUST that extension. My and CCleaner's thoughts are that the extension code is pointing to the wrong place in CCleaner... I am not a coder, but that makes sense to me!

Actual Context Menu CCleaner list of Context Menu items