search

GoogleChromeLabs / native-url

Node's url module implemented using the built-in URL API.
https://npm.im/native-url
Apache License 2.0
284 stars 11 forks source link

Fix port/path/auth conflict #28

Closed Janpot closed 4 years ago

Janpot commented 4 years ago

Make sure to do the port rewrite only when it's part of the host of an absolute url

edit:

Did a quick code review and found that this port replace also clashes with basic auth. It seems like a fix can be written with less code, so double win, I guess...

Fixes https://github.com/GoogleChromeLabs/native-url/issues/27