Removing non standard protocol from constants. Rewrite logic to work …

GoogleChromeLabs / native-url

Node's url module implemented using the built-in URL API.

https://npm.im/native-url

Apache License 2.0

284 stars 11 forks source link

Removing non standard protocol from constants. Rewrite logic to work … #9

Closed janicklas-ralph closed 4 years ago

janicklas-ralph commented 4 years ago

…with http://

Non standard protocol parsing doesn't work well with url-polyfill. Breaks in nomodule browsers

[x] Tests pass
[x] Appropriate changes to README are included in PR

Timer commented 4 years ago

I don't see a test added for this behavior. 😄

janicklas-ralph commented 4 years ago

So there are multiple tests for the resolve method that cover these cases, but right now we only do browser testing with chrome. This specific test fails only with the polyfill thats used in browsers that don't support URL. So we need to tests to run on different browsers.

I'll look into setting up a Saucelabs account or something similar that would run the tests on different browsers.