search

GoogleChromeLabs / perf-track

Tracking framework performance and usage at scale
https://perf-track.web.app/
Apache License 2.0
150 stars 12 forks source link

fixed style issue #16 #17

Closed PraveenPal4232 closed 4 years ago

PraveenPal4232 commented 4 years ago

Hi @housseindjirdeh please check this I just solved this "Framework pages style issue #16".

Thanks

housseindjirdeh commented 4 years ago

Thanks for this @PraveenPal4232!

There's the small issue of larger screen sizes, where an "auto" height doesn't fill out the page:

Screen Shot 2020-07-13 at 1 58 26 PM

We may have to use a combination of min-height: 100% and then ensure the inner containers + grid items fit the size of the screen.

PraveenPal4232 commented 4 years ago

Oh my bad, let me fix this

PraveenPal4232 commented 4 years ago

Hi @housseindjirdeh Let's have a look again, now it is looking fine.

Thanks

PraveenPal4232 commented 4 years ago

Thanks, @housseindjirdeh for merging my PR :)