search

GoogleChromeLabs / picture-in-picture-chrome-extension

https://chrome.google.com/webstore/detail/hkgfoiooedgoejojocmhlaklaeopbecg
Apache License 2.0
680 stars 157 forks source link

[WIP] Mv3 optimizations #78

Open nopeless opened 2 years ago

nopeless commented 2 years ago

Update to manifestation version 3

This PR also includes minor performance optimizations and code fixes

backgrounnd.js currently cannot use attributes from document as manifest v3 does not expose that variable to the code.

If anyone knows how to fix this, please let me know

Thanks

google-cla[bot] commented 2 years ago

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

beaufortfrancois commented 2 years ago

Thank you @nopeless I've started a PR as well to migrate it to MV3 at https://github.com/GoogleChromeLabs/picture-in-picture-chrome-extension/pull/79 Let me know what you think

beaufortfrancois commented 2 years ago

@nopeless I've just published v1.11 with MV3 support.