search

GoogleChromeLabs / picture-in-picture-chrome-extension

https://chrome.google.com/webstore/detail/hkgfoiooedgoejojocmhlaklaeopbecg
Apache License 2.0
680 stars 157 forks source link

Keyboard shortcut not working #80

Closed rohandhruva closed 1 year ago

rohandhruva commented 2 years ago

The keyboard shortcut (Option-P) stopped working for me on macOS with Google Chrome Beta and Canary. The only way to trigger PIP is now to press the button in the Chrome toolbar.

The versions of chrome are:

Please let me know what other information will be useful to triage/debug this issue.

beaufortfrancois commented 2 years ago

Do you still see the ⌥P keyboard shortcut in chrome://extensions/shortcuts?

image

rohandhruva commented 2 years ago

Yes, I confirm that it is still ⌥P in both the versions of Chrome I shared above.

EliaECoyote commented 2 years ago

👋 Had the same issue. Editing the keyboard shortcut in chrome://extensions/shortcuts and typing ⌥P again solved it for me.

beaufortfrancois commented 2 years ago

Argh. That is sad. I don't know if it's because of the MV3 extension update. I'll ask around.

beaufortfrancois commented 2 years ago

FYI I've filed https://bugs.chromium.org/p/chromium/issues/detail?id=1371857 to let the chrome team about this issue

luckman212 commented 2 years ago

Same issue (macOS + Chrome 106.0.5249.119). Manually editing the keyboard shortcut and re-typing ⌥P "fixed" it for me. Even though prior to doing so, it was already set to that same shortcut.

chromer030 commented 1 year ago

Same issue , on Linux , ALT + P doesn't work. Google Chrome 108 Arch Linux.

beaufortfrancois commented 1 year ago

The Chromium team has finally fixed this issue. See https://chromiumdash.appspot.com/commit/a98898b9615f2e454ec02917c720f479f29e673f

It doesn't change anything for this extension as we've upgraded to MV3 already.

chromer030 commented 1 year ago

@beaufortfrancois , Thanks for the fix , We should wait for version 111 , or it possibly could be backported ?

beaufortfrancois commented 1 year ago

I cannot be backported sadly. This extension has been migrated to MV3 already, which means users lost the keyboard shortcut and need to re-add it it again manually in chrome://extensions/shortcuts.