fix #18: nested props are ignored if the first one is undefined

GoogleChromeLabs / postcss-jit-props

A CSS custom property helper based on PostCSS. Supply a pool of variables and this plugin will add them to the stylesheet as they are used.

https://stackblitz.com/edit/jit-open-props?file=postcss.config.js

Apache License 2.0

210 stars 9 forks source link

fix #18: nested props are ignored if the first one is undefined #19

Closed benbender closed 2 years ago

benbender commented 2 years ago

I did a little research on #18 and it turns out that the bug is only present if the first prop is undefined. This pr fixes the issue and adds a test-case.

closes #18

google-cla[bot] commented 2 years ago

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

For more information, open the CLA check for this pull request.

argyleink commented 2 years ago

sorry reviewing these great PRs took a few days, been afk

benbender commented 2 years ago

@argyleink No prob. Living outside of github is a thing I've heard of ;)

(Edit: Didn't saw the release. Need moar coffee...)