GoogleChromeLabs / postcss-jit-props

A CSS custom property helper based on PostCSS. Supply a pool of variables and this plugin will add them to the stylesheet as they are used.
https://stackblitz.com/edit/jit-open-props?file=postcss.config.js
Apache License 2.0
219 stars 9 forks source link

implement file dependency messages #32

Closed romainmenke closed 1 year ago

romainmenke commented 1 year ago

This looks like a massive change because the indent changed by wrapping everything in prepare.

Changed :

see : https://github.com/GoogleChromeLabs/postcss-jit-props/issues/24#issuecomment-1378342599

I am unsure how widespread the support for dependency messages through PostCSS is. Some tools might support it, others might not. PostCSS CLI definitely supports it and it is clearly documented in the guidelines for PostCSS

But I personally do not think it is up to plugins to implement file watching through things like chokidar. Better to leave this up to builders, bundlers, meta frameworks, ...

romainmenke commented 1 year ago

Awesome!

Thank you for reviewing and releasing these 🙇