search

GoogleChromeLabs / progressive-tooling

A list of community-built, third-party tools that can be used to improve page performance
https://progressivetooling.com/
Apache License 2.0
546 stars 32 forks source link

Replacing invalid schema markup with json-ld syntax #32

Closed scottmathson closed 5 years ago

scottmathson commented 5 years ago

Previous markup missing both itemscope and itemtype and isn't valid. Since not marked-up in body and in keeping this in the <head>, introducing JSON-LD instead, declaring type, etc.

housseindjirdeh commented 5 years ago

So awesome, thanks a ton for this 🎉 (and TIL that format isn't valid :))

scottmathson commented 5 years ago

Absolutely, thanks for quick response!

scottmathson commented 5 years ago

@housseindjirdeh does this app need re-built? Not seeing changes on production still.

housseindjirdeh commented 5 years ago

@scottmathson it did need to get rebuilt 😅

Just pushed it up. Thanks again 🙏