search

GoogleChromeLabs / proxx

A game of proximity
https://proxx.app
Apache License 2.0
1.31k stars 124 forks source link

right-click probably needs an evt.preventDefault()? #441

Open Pomax opened 5 years ago

Pomax commented 5 years ago

Right clicking any of the buttons in Firefox, pops up the context menu in addition to doing what it's supposed to:

image

So this probably needs an evt.preventDefault() added the click handler?

kosamari commented 5 years ago

Hiya @Pomax hmmm there should be preventDefault already... I've tried both FF on mac and windows but unable to reproduce this. What's your set up??

Pomax commented 5 years ago

Hmm... this is on Win10 running FF nightly, with noscript set to allow proxx (but not GA) and adblock paused.

A quick bit of testing suggests that neither preventDefault() or onContextMenu = (() => false); seem to actually prevent that context menu from popping up, so I guess I'll have to see if there's some crazy setting that prevents JS from interfering with the context menu in Nightly...