search

GoogleChromeLabs / proxx

A game of proximity
https://proxx.app
Apache License 2.0
1.31k stars 124 forks source link

Add basic vim-alike keyboard bindings #451

Open ZaneHannanAU opened 5 years ago

ZaneHannanAU commented 5 years ago

This commit adds case-insensitive vim-alike (hjkl only) keyboard bindings, as well as using space as a way to (destroy?) a focused block.

kosamari commented 5 years ago

@ZaneHannanAU thanks for PR. the PR looks fine, but bigger question is if we want to keep adding different key support or move this to something separate so that user can set their own modification (see #103)

@surma @jakearchibald what's your take?

ZaneHannanAU commented 5 years ago

In that case, I had a thing which… looks more like a key binding library than anything, over at https://gitlab.com/zeen3/z3-mng-reader

Main stuff is in /src/sw, /src/dom and /src/common but ehhh…

surma commented 5 years ago

I’m happy to add spacebar support, I am not too keen on hjkl ;)

ZaneHannanAU commented 5 years ago

I'm guessing it causes issues with accessibility?

Most of it is because I'd need to move from the home row lol

richiksc commented 5 years ago

I'd prefer using WASD since it's used in so many games.

everdimension commented 4 years ago

Although I love using vim-bindings for navigation, I think WASD support is a really great idea because it would reinforce the game feel and the idea that the web is a capable platform for apps.