Add share button to win screen

richiksc commented 5 years ago

It uses the Web Share API and adds a button below the main menu button on the win screen. The share text follows this pattern:

Can you beat my score of 1:37 on easy mode? Play PROXX now. https://proxx.app

googlebot commented 5 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.

What to do if you already signed the CLA

Individual signers

It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
The email used to register you as an authorized contributor must also be attached to your GitHub account.

ℹ️ Googlers: Go here for more info.

richiksc commented 5 years ago

I need to style the share icon so it is the correct color and size.

googlebot commented 5 years ago

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

richiksc commented 5 years ago

I've styled the share icon, but it's impossible to test locally due to the Windows bug described in #457. It should work in the deploy preview.

jakearchibald commented 5 years ago

I was going to wait until image sharing was possible before landing something like this, but maybe that's overkill.

The styling is a bit broken, mostly because you couldn't test it properly, but I'm happy to help get this over the line.

richiksc commented 5 years ago

What does the styling look like right now? It's very difficult to work on visual styles if you can't test the code. Ideally, we would fix #457 and I could test it myself, but if anyone else wants to iron out the styling bugs, that would be amazing. Also, I'm thinking of adding a Clipboard API fallback for browsers (such as desktop browsers) that don't support the Web Share API which would copy the share text to the clipboard. Would this be functionality you would like to see?

richiksc commented 5 years ago

Quick question - the deploy preview on Netlify didn't rebuild on commit 9f839e105941ef46f9075a30d690800c58afd1c3, is there a way to get it to update so I can preview the build?

surma commented 5 years ago

Hm, I think Netlify might not handle re-opened PRs very well. If you want, close this PR and open a new one so Netlify is back in action :)

richiksc commented 5 years ago

Closing this PR and opening a new one to make Netlify work.

GoogleChromeLabs / proxx