GoogleChromeLabs / proxx

A game of proximity
https://proxx.app
Apache License 2.0
1.32k stars 125 forks source link

bombs above the scroll bar #499

Open dtudury opened 5 years ago

dtudury commented 5 years ago

Debug info Version: 1.0.9 Motion: true Supports WebGL: true Feature Phone: no Standalone Mode: no Screen Width: 749px Screen Height: 821px DPR: 1 Device Memory: 8 Concurrency: 4 UA: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_14_1) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/76.0.3809.100 Safari/537.36

Describe the bug in the lose state, on maps with scroll bars, the bombs appear above the scroll bar

To Reproduce Steps to reproduce the behavior:

  1. lose
  2. resize until you get scroll bars
  3. scroll a bomb to the right edge
  4. see the bomb go over the scroll bar

Expected behavior the bombs should be under the scroll bar.

switching the order of the main canvas and the div that wraps the table seems to fix it (~I tried to fix it in a fork but it wasn't as simple to add as I'd anticipated~ EDIT: PR below)