GoogleChromeLabs / proxx

A game of proximity
https://proxx.app
Apache License 2.0
1.31k stars 124 forks source link

Automate prevention of accidentally increasing entry bundle size #509

Open tjenkinson opened 4 years ago

tjenkinson commented 4 years ago

I watched your jsconf presentation on making things fast (which was great by the way) and towards the end you mentioned including warning comments to try and prevent accidentally importing something into the entry bundle.

I thought there must be a way of automating this, so that the comments could actually enforce it, and put together a rollup plugin

Interested to know what you think

The result of this PR is if you try and import something from a module that is in the entry group, that is not itself in the entry group (or an exception in the config), it will error out.

tjenkinson commented 4 years ago

bump @jakearchibald @surma :)

tjenkinson commented 2 years ago

bump @jakearchibald @surma

If you don’t want this we can close it and I’ll stop the yearly ping ;)