GoogleChromeLabs / proxx

A game of proximity
https://proxx.app
Apache License 2.0
1.31k stars 124 forks source link

Test SW build (Attempt #1) #512

Closed NicholasPeretti closed 4 years ago

NicholasPeretti commented 4 years ago

I've tried to build the service worker ONLY. It kinda works, but if I remove the first two lines of the src/sw/index.ts file (those imports), and I replace them with constants, tsc -b gives me compilation errors 🤔

I'd expect this to work.

In order to test it, clone this branch, comment the line 1 and 2 in the src/sw/index.ts file and de-comment the line 6 and 7 in the same file. The result should be this:

// import version from "consts:version";
// import resourceList from "resource-list:";
// Give TypeScript the correct global.
declare var self: ServiceWorkerGlobalScope;

const version = 2;
const resourceList: Array<string> = [];

Then, you can try to compile by running tsc -b in src/sw/

googlebot commented 4 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

jakearchibald commented 4 years ago

Closing, since this isn't a pull request.