Closed queq1890 closed 3 years ago
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
:memo: Please visit https://cla.developers.google.com/ to sign.
Once you've signed (or fixed any issues), please reply here with @googlebot I signed it!
and we'll verify it.
ℹ️ Googlers: Go here for more info.
@googlebot I signed it!
That's fair, although it's a pattern we use on other projects, and the code isn't doing any harm (it doesn't end up in a client bundle). I guess we should publish the asset plugin to npm.
@jakearchibald
it's a pattern we use on other projects, and the code isn't doing any harm (it doesn't end up in a client bundle)
makes sense to me. Thank you for the quick response 😄
While walking through proxx's Rollup config, I found that id with
asset-url:
prefix no longer exists. So I think we can removeresolveId
hook andload
hook that used to deal with such ids.