GoogleChromeLabs / proxx

A game of proximity
https://proxx.app
Apache License 2.0
1.31k stars 124 forks source link

Remove resolveId hook and load hook from asset-plugin #517

Closed queq1890 closed 3 years ago

queq1890 commented 3 years ago

While walking through proxx's Rollup config, I found that id with asset-url: prefix no longer exists. So I think we can remove resolveId hook and load hook that used to deal with such ids.

googlebot commented 3 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

queq1890 commented 3 years ago

@googlebot I signed it!

googlebot commented 3 years ago

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

jakearchibald commented 3 years ago

That's fair, although it's a pattern we use on other projects, and the code isn't doing any harm (it doesn't end up in a client bundle). I guess we should publish the asset plugin to npm.

queq1890 commented 3 years ago

@jakearchibald

it's a pattern we use on other projects, and the code isn't doing any harm (it doesn't end up in a client bundle)

makes sense to me. Thank you for the quick response 😄