Fix: Add `Blocked` status in CSV report - Githubissues

GoogleChromeLabs / ps-analysis-tool

Privacy Sandbox Analysis Chrome Extension and CLI for analysis and understanding of cookie usage on web pages, and new privacy-preserving Chrome APIs

https://www.privacysandbox.com

Apache License 2.0

97 stars 22 forks source link

Fix: Add `Blocked` status in CSV report #661

Closed mayan-000 closed 5 months ago

mayan-000 commented 5 months ago

Description

This PR adds code to add Blocked status in the Blocking status column when the CSV file is downloaded.

Relevant Technical Choices

Testing Instructions

Open the PSAT panel and enable CDP.
Open the cookie table on the first frame.
Find the download icon beside the search bar and click it.
Open the downloaded file and scroll to the last column.
The Blocking status column should have the value Blocked for some cookies.

Additional Information:

Screenshot/Screencast

Screenshot 2024-05-06 at 14 55 19

Checklist

[x] I have thoroughly tested this code to the best of my abilities.
[x] I have reviewed the code myself before requesting a review.
~This code is covered by unit tests to verify that it works as intended.~
[x] The QA of this PR is done by a member of the QA team (to be checked by QA).

Fixes #

mohdsayed commented 5 months ago

Closing as this is not requried for the following reasons.

A cookie having yellow row doesn’t necessarily mean that the cookie was blocked, it just means that it was blocked in at least one of the request or response. Therefore mentioning that the cookie was blocked would be misleading.
PR#539 will remove this column in the next version, so it would anyways not be required.