Fix: Retention period cookie filter - Githubissues

GoogleChromeLabs / ps-analysis-tool

Privacy Sandbox Analysis Chrome Extension and CLI for analysis and understanding of cookie usage on web pages, and new privacy-preserving Chrome APIs

https://www.privacysandbox.com

Apache License 2.0

91 stars 20 forks source link

Fix: Retention period cookie filter #665

Closed mayan-000 closed 2 months ago

mayan-000 commented 2 months ago

Description

This PR adds code to update the default value returned by calculateEffectiveExpiryDate to Session. And take care of assignments/processing of required files.

Because of the above change, the retention period filter can properly filter out rows due to consistent values.

Relevant Technical Choices

Testing Instructions

Open the PSAT panel, and navigate to the first frame.
Open the filters sidebar and open the retention period filter.
Select Session filter value, the rows showing data should have Session value in the expires column.

Additional Information:

Screenshot/Screencast

https://github.com/GoogleChromeLabs/ps-analysis-tool/assets/58820001/771e56cf-bb8b-4512-bdc7-ff03bc7baede

Checklist

[x] I have thoroughly tested this code to the best of my abilities.
[x] I have reviewed the code myself before requesting a review.
[x] This code is covered by unit tests to verify that it works as intended.
[x] The QA of this PR is done by a member of the QA team (to be checked by QA).

Fixes #