Closed mayan-000 closed 2 weeks ago
-l
option test, duplicate filter values for True, False options.npm run cli -- -u https://bbc.com -l hi
[x] [QA] CLI Known breakage section not working, possibly related to https://github.com/GoogleChromeLabs/ps-analysis-tool/issues/716#issuecomment-2175484727
[x] QA CLI Need Improved error messaging
Suggest languages available supported: en, hi, ja, ko, pt-BR
npm run cli -- -u https://www.math-only-math.com/ -l
> ps-analysis-tool@0.8.0 cli
> node packages/cli/dist/main.js "-u" "https://www.math-only-math.com/" "-l"
error: option '-l, --locale <value>' argument missing
It should validate an invalid value being passed for -l argument not valid locale option, currently supported: en, hi, ja, ko, pt-BR
╭─milind at Milind’s MacBook Air in ~/projects/ps-analysis-tool on feat/implement-i18n✔ using
╰─± npm run cli -- -u https://www.math-only-math.com/ -l st
> ps-analysis-tool@0.8.0 cli
> node packages/cli/dist/main.js "-u" "https://www.math-only-math.com/" "-l" "st"
✓ Done analyzing cookies.
✓ Done analyzing technologies.
Report created successfully: /Users/milind/projects/ps-analysis-tool/out/www-math-only-math-com/index.html
[QA]
pt-BR
instead pt_BR
Description
This PR implements the i18n getMessage function across strings whose translations are available.
getMessage
andgetFormattedMessage
functions for extracting required text for a key from JSON files.Relevant Technical Choices
-l --locale
flag to prompt users for the locale they want.Testing Instructions
Additional Information:
Screenshot/Screencast
Checklist
Fixes #566