search

GoogleChromeLabs / ps-analysis-tool

Privacy Sandbox Analysis Chrome Extension and CLI for analysis and understanding of cookie usage on web pages, and new privacy-preserving Chrome APIs
https://www.privacysandbox.com
Apache License 2.0
97 stars 22 forks source link

[QA] - Develop branch #716

Closed pavanpatil1 closed 3 months ago

pavanpatil1 commented 3 months ago
pavanpatil1 commented 3 months ago

The exemption cookie section is not visible in the HTML report. On the landing page, the section appears even when no exemption reason is present. However, after downloading the HTML report, this section is missing.

image

pavanpatil1 commented 3 months ago

In the Chrome Canary browser, a React minified error occurs after performing certain operations such as table sorting and filtering.

image

image

pavanpatil1 commented 3 months ago

Known breakages are not functioning correctly in the CLI. Despite GIS and GSI being present on the site, the count is showing as 0 in the CLI.

image

pavanpatil1 commented 3 months ago

A long trace error is visible after executing a sitemap command. This issue occurs randomly and is observed when the command includes any invalid parameter or if the URL does not exist.

image

pavanpatil1 commented 3 months ago

Add validation in the CLI. Currently, when executing the sitemap/CSV file, the CLI parses the file and allows the user to enter the number of URLs to execute. However, there is no validation for the user input, allowing any number to be entered.

image

pavanpatil1 commented 3 months ago

Applying filters or any other table operation in one report reflects another one in a different tab in the CLI.Currently, if a user opens reports for two sites and changes one, those changes are replicated in the other.

dataexchange.webm

pavanpatil1 commented 3 months ago

While executing sitemap or CSV commands in the CLI, the menu bar scroller on the cookie landing page does not working correctly.

sitemapscroll (1).webm

pavanpatil1 commented 3 months ago

On the RWS page, the "Rationale" text currently has an underline. This underline should be removed.

image

pavanpatil1 commented 3 months ago

observed this issue randomly on the extensions page. After performing some operations like sorting/applying filters, the issue appeared.

image

pavanpatil1 commented 3 months ago

The count for functional categories on the cookie landing page is not displayed accurately.

count.webm

pavanpatil1 commented 3 months ago

The exempted cookie section should be non-clickable when there are no cookies present.

image

milindmore22 commented 3 months ago

CLI : Adding invalid path to sitemap gives blank results. It detected 0 sitemaps, still asked for the number of pages to analyze.

Provided Sitemap has 0 pages. Please enter the number of pages you want to analyze (Default 0): 5

npm run cli -- -s https://rtcamp.com/sitemap-post.xml

> ps-analysis-tool@0.8.0 cli
> node packages/cli/dist/main.js "-s" "https://rtcamp.com/sitemap-post.xml"

✓ Done parsing Sitemap
Provided Sitemap has 0 pages. Please enter the number of pages you want to analyze (Default 0): 5
✓ Done analyzing cookies.
✓ Done analyzing technologies.
Report created successfully: /Users/milind/projects/ps-analysis-tool/out/rtcamp-com-sitemap-post-xml/index.html
milindmore22 commented 3 months ago

CLI : When running CSV analysis, the "Unknown Frames" appear on top of the main frame for second website onwards listed in CSV file

File tested psat-csv-test.csv

https://github.com/GoogleChromeLabs/ps-analysis-tool/assets/1132541/50ec5fef-3946-4711-bc59-f4b53bc8ec1b

milindmore22 commented 3 months ago

Update : Unable to reproduce possibly old build CLI : Reports downloaded from PSAT CLI Dashboard for CSV test have blank reports.html files

psat_cli_report_bbc-com_19062024.zip

image

ayushnirwal commented 3 months ago

CLI : When running CSV analysis, the "Unknown Frames" appear on top of the main frame for second website onwards listed in CSV file

@milindmore22 There should be no key for unknown frames in the site reports. This has been removed in the commit 805a508

milindmore22 commented 3 months ago

CLI : Found a fatal error while running analysis for CSV file, on URL's which has known brekages 

npm run cli -- -c /Users/milind/Downloads/psat-csv-test.csv     

> ps-analysis-tool@0.8.0 cli
> node packages/cli/dist/main.js "-c" "/Users/milind/Downloads/psat-csv-test.csv"

✓ Done parsing CSV file
Provided CSV file has 7 pages. Please enter the number of pages you want to analyze (Default 7): 7
node:internal/process/promises:288visit
            triggerUncaughtException(err, true /* fromPromise */);
            ^

Error [TypeError]: Cannot read properties of null (reading 'appendChild')
pptr:evaluateHandle;i.addScriptTag%20(%2FUsers%2Fmilind%2Fprojects%2Fps-analysis-tool%2Fpackages%2Fcli%2Fdist%2Fmain.js%3A3%3A916719):1:338
    at evaluateHandle (evaluateHandle at i.addScriptTag (/Users/milind/projects/ps-analysis-tool/packages/cli/dist/main.js:3:916719), <anonymous>:0:337)
    at evaluateHandle (evaluateHandle at i.addScriptTag (/Users/milind/projects/ps-analysis-tool/packages/cli/dist/main.js:3:916719), <anonymous>:0:45)
    at #Vt (/Users/milind/projects/ps-analysis-tool/packages/cli/dist/main.js:3:977237)
    at async Xn.evaluateHandle (/Users/milind/projects/ps-analysis-tool/packages/cli/dist/main.js:3:975582)
    at async nr.evaluateHandle (/Users/milind/projects/ps-analysis-tool/packages/cli/dist/main.js:3:983368)
    at async i.addScriptTag (/Users/milind/projects/ps-analysis-tool/packages/cli/dist/main.js:3:916692)
    at async Dr.addScriptTag (/Users/milind/projects/ps-analysis-tool/packages/cli/dist/main.js:3:929123)

Node.js v18.1.0
milindmore22 commented 3 months ago

CLI Enhancement : add file:// protocol for the report generated, so user can click to view CLI reports.

pavanpatil1 commented 3 months ago

In CLI, even when no exempted cookies are present on the site, the cookie landing page should display the count, similar to the extension. This count should be accurately reflected on the cookie landing page.

milindmore22 commented 3 months ago

Errors on the extension panel when using single sign-on demo.

Steps :

  1. Enter email ID and sign-in
  2. Log out
  3. Click on Sign-in again
  4. Repeat several times.
Uncaught (in promise) TypeError: Cannot read properties of undefined (reading 'id')
Context
service-worker.js
Uncaught (in promise) Error: No tab with given id 584215054.
Context
service-worker.js

https://github.com/GoogleChromeLabs/ps-analysis-tool/assets/1132541/dea37bc0-cc80-47c3-a48b-5b4d0c4b1190

pavanpatil1 commented 3 months ago

CLI: If there are "0" blocked cookies present on the site, the blocked cookies section on the cookie landing page should be unclickable.

blocked.webm

milindmore22 commented 3 months ago

Extension fails on livemint.com with an error Cannot read properties of undefined (reading 'color') Please try opening this page in a new tab.

https://github.com/GoogleChromeLabs/ps-analysis-tool/assets/1132541/2714afda-b465-4aea-965c-937adebad09a

milindmore22 commented 3 months ago

CLI: Missing message for exempted cookies section when there are no cookies found.

On the extension, we have No cookies were exempted by the browser.

Screen Shot 2024-06-21 at 7 55 45 PM

milindmore22 commented 3 months ago

CLI : Missing column heading in exported CSV files using -d CLI options

npm run cli -- -u https://nationalgeographic.com/ -d /Users/milind/Downloads/Output

pavanpatil1 commented 3 months ago

When downloading the CSV file from the table, the "same site" column value is not visible in the CSV.

image

maitreyie-chavan commented 3 months ago

Addressed in v0.9