GoogleChromeLabs / ps-analysis-tool

Privacy Sandbox Analysis Chrome Extension and CLI for analysis and understanding of cookie usage on web pages, and new privacy-preserving Chrome APIs
https://www.privacysandbox.com
Apache License 2.0
96 stars 22 forks source link

Sorting filter not working properly on PSAT report tables #764

Open Dbrown910 opened 1 month ago

Dbrown910 commented 1 month ago

Describe the bug When viewing the Technologies tab of a report generated by PSAT CLI, the sorting filter does not categorize the rows alphabetically. See screenshot added.

To Reproduce Steps to reproduce the behavior:

  1. Run npx @google-psat/cli https://vox.com
  2. Click on the vox.com site report
  3. Click on the Technologies tab
  4. Click Category to sort the rows by category
  5. See error - rows are not sorted alphabetically as expected

Expected behavior The rows should be ordered alphabetically ascending or descending

Screenshots If applicable, add screenshots to help explain your problem.

Screenshot 2024-07-19 at 4 53 34 PM

Desktop (please complete the following information):

Additional context Add any other context about the problem here.

milindmore22 commented 1 month ago

Hello @Dbrown910

Thank you for bringing this to our attention! We appreciate you taking the time to report the bug, we acknowledge the sorting filter in the technologies tab of the PSAT CLI and npm package (v0.9) report is not categorizing rows alphabetically.

We are working on a fix that will be included in an upcoming PSAT release. Meanwhile, if you have any questions or require further assistance, please don't hesitate to reach out on support forums

milindmore22 commented 1 month ago

Hello @Dbrown910,

We're excited to announce the release of version 0.10.0! This update addresses the category sorting issue in the technology analysis report that you brought to our attention.

However, please note that there are some changes to the PSAT CLI options. We've made technology analysis optional. This means users will need to explicitly opt in for technology analysis by using flag -t eg: npx @google-psat/cli https://vox.com -t or npm run cli -- -u https://vox.com -t

For detailed information about the CLI option changes, we recommend checking the wiki or the npm package README.

Please let us know if you have any questions.