GoogleChromeLabs / ps-analysis-tool

Privacy Sandbox Analysis Chrome Extension and CLI for analysis and understanding of cookie usage on web pages, and new privacy-preserving Chrome APIs
https://www.privacysandbox.com
Apache License 2.0
100 stars 23 forks source link

[QA] - v0.11 release branch #834

Closed pavanpatil1 closed 1 month ago

pavanpatil1 commented 1 month ago

Need Steps to reproduce

Unable to reproduce

Wontfix

Next Release

pavanpatil1 commented 1 month ago

Keyboard navigation isn't working when focused on 'Related website sets.

keyboard.webm

pavanpatil1 commented 1 month ago

The "Reload All" button isn't displaying correctly on the landing pages.

Screenshot 2024-09-10 at 12 34 22 PM
pavanpatil1 commented 1 month ago

When the Extensions tab in DevTools is opened while on the first tab, the main landing page is correctly displayed. However, after switching to a new tab and then reopening the DevTools Extensions tab, the dashboard page appears instead of the main landing page. Main privacy sandbox landing page to be visible across all tabs.

dashboard.webm

pavanpatil1 commented 1 month ago

In the EasyDigitalSurvey frame, although the cookies are present, the background remains gray, indicating that no cookies are currently detected.

URL - https://www.bbc.com/

Note: The CDP is disabled and the analysis is limited to a single tab.

Screenshot 2024-09-11 at 10 18 34 AM
pavanpatil1 commented 1 month ago

There's a small typo on the Private Advertising page.

Screenshot 2024-09-11 at 11 50 35 AM
pavanpatil1 commented 1 month ago

The Frameoverlay icon does not display correctly after the DevTools dock is moved to a detached position and then repositioned to the right.

Screenshot 2024-09-11 at 12 05 36 PM
milindmore22 commented 1 month ago

Wiki section headings show dashes when clicking on sub menus from sidebar.

https://github.com/user-attachments/assets/d1f09f1c-4d4d-4724-8902-f5551e81ff5a

fellyph commented 1 month ago

For the icons on the collapsed sidebar, can we use the full width for the icons or align them in the center of the column?

Screenshot 2024-09-11 at 11 24 19 Screenshot 2024-09-11 at 11 24 14 Screenshot 2024-09-11 at 11 24 07 Screenshot 2024-09-11 at 11 24 01
fellyph commented 1 month ago

On the related website sets, there are two items:

https://github.com/user-attachments/assets/8db8fe8d-8cb4-4c1a-8d21-fb732ab10b94

links:

Screenshot 2024-09-11 at 11 43 09 Screenshot 2024-09-11 at 11 42 15
pavanpatil1 commented 1 month ago

Errors are visible on the extension page.

Screenshot 2024-09-11 at 4 37 11 PM
pavanpatil1 commented 1 month ago

After downloading the report from the extension, the version in the report.html file is mismatch.

Screenshot 2024-09-11 at 5 14 49 PM
fellyph commented 1 month ago

https://github.com/user-attachments/assets/8e35ba0b-0c5b-4355-9e41-8765c1cfadcc

milindmore22 commented 1 month ago

Disable the “Download” button in the extension when there are no cookies on the page.

Check it on https://example.com/

Screen Shot 2024-09-12 at 2 22 03 PM

fellyph commented 1 month ago

https://github.com/user-attachments/assets/96523f69-4a16-431b-8657-88cf1e8d68b4

milindmore22 commented 1 month ago

The sidebar width is inconsistent when user adjust it and use the collapsible sidebar feature.

  1. When user increase the sidebar width, it should remain consistent.
  2. The sidebar resets to default width after using from collapsible sidebar.

https://github.com/user-attachments/assets/0fce6916-3747-43e7-a8a9-50d07b9f6ebc

gagan0123 commented 1 month ago

Wiki in PSAT Panel does not render mermaid diagrams and shows the source code instead

Screenshots:

  1. In PSAT Panel image

  2. In GitHub Wiki image

gagan0123 commented 1 month ago

Inconsistent scrolling behavior on page switch between navigation menu items in wiki

Steps to replicate:

  1. Open the wiki in Privacy Sandbox panel.
  2. Navigate to any page, for example, "Known Breakages".
  3. Now, click on a different heading in the left navigation menu, for example, "Filtering". Observe: The page scrolls to the bottom first and then scrolls back up to the "Filtering" section.
  4. Now, click on "Known Breakages" again from the left navigation menu. Observe: This time, the page scrolls directly to the "Known Breakages" section without first going to the bottom of the page.

Screencast:

https://github.com/user-attachments/assets/139d4be3-fee4-466a-8a9b-45dabcd72019

Expected Behavior:

Regardless of the user's previous scroll position or the page they were on, clicking on a navigation menu item should always result in the following consistent behavior:

  1. On a page change, start from the top of the page.
  2. Scroll to the clicked heading's position on the page.
fellyph commented 1 month ago
  1. Navigate to ge.globo.com/futebol/times/corinthians/
  2. Open the extension on DevTools
  3. Run the audit
  4. Download the report
  5. Compare the data between the report
Screenshot 2024-09-12 at 14 58 56 Screenshot 2024-09-12 at 14 59 00
gagan0123 commented 1 month ago

Intermittent inconsistent cookie counts between Popup and PSAT Panel

Description:

The cookie counts displayed in the PSAT popup and PSAT panel are inconsistent for a short time, with the popup updating faster than the panel. This discrepancy creates confusion for the user, as the counts displayed in the two locations don't match for a noticeable period, sometimes lasting multiple seconds.

Steps to Reproduce:

  1. Open PSAT Panel.
  2. Navigate to https://natgeo.com
  3. Open the PSAT popup. Observe the initial cookie counts (initially all zeros).
  4. Observe that the cookie counts in the popup update quickly as the page loads, but the panel remains stuck on the initial counts for a short duration.

Screencast:

https://github.com/user-attachments/assets/b2b3ddec-d01a-4024-bcfe-cfcf371bec3c

Expected Behavior:

The cookie counts displayed in both the PSAT popup and the DevTools panel should update concurrently as cookies are set by the website. This would ensure consistency in the data presented to the user and prevent confusion about PSAT's accuracy.

mohdsayed commented 1 month ago

After downloading the report from the extension, the version in the report.html file is mismatch.

Screenshot 2024-09-11 at 5 14 49 PM

@pavanpatil1 Actually, there shouldn't be a download button in the downloaded report.

pavanpatil1 commented 1 month ago

The version number does not appear in the report.html file when using the CLI.

Screenshot 2024-09-13 at 4 19 18 PM
fellyph commented 1 month ago

CLI report

Issues

Screenshot 2024-09-13 at 11 38 40 Screenshot 2024-09-13 at 11 40 50 Screenshot 2024-09-13 at 12 06 34 Screenshot 2024-09-13 at 12 06 48 Screenshot 2024-09-13 at 12 09 56

Suggestion

fellyph commented 1 month ago

Site boundaries section, the portuguese version has some issues with the height of the card:

Screenshot 2024-09-13 at 14 57 59
pavanpatil1 commented 1 month ago

The extra whitespace becomes visible on the wiki page when the page refresh notification is displayed.

Screenshot 2024-09-16 at 9 37 45 AM
mohdsayed commented 1 month ago

Errors are visible on the extension page.

Screenshot 2024-09-11 at 4 37 11 PM

@pavanpatil1 Can you give us steps to reproduce it?

mohdsayed commented 1 month ago
  • The total amount of cookies is inconsistent between the downloaded report and the extension
  1. Navigate to ge.globo.com/futebol/times/corinthians/
  2. Open the extension on DevTools
  3. Run the audit
  4. Download the report
  5. Compare the data between the report

Screenshot 2024-09-12 at 14 58 56 Screenshot 2024-09-12 at 14 59 00

@fellyph Does it happen on new profile or regular one?

mohdsayed commented 1 month ago

CLI report

Issues

  • [ ] Can we localize the date at the top of the report
  • [ ] Small color difference on light mode for the message under cookie exempted and know breakages

Screenshot 2024-09-13 at 11 38 40 Screenshot 2024-09-13 at 11 40 50

  • [ ] Error using option -o the terminal crashed with npm run cli -- https://globo.com -o ./out/test/
  • [ ] Error running npm run cli -- https://globo.com -o test/ the report was created, but the terminal triggered an error
  • [ ] running a report with -o there is no link to the generated file like Report: file:///Users/fellyph...

Screenshot 2024-09-13 at 12 06 34 Screenshot 2024-09-13 at 12 06 48 Screenshot 2024-09-13 at 12 09 56

Can we localize the date at the top of the report

@fellyph There are too many timezones which would need to be translated in all the languages we are supporting. We can take this one later.

mohdsayed commented 1 month ago

When the Extensions tab in DevTools is opened while on the first tab, the main landing page is correctly displayed. However, after switching to a new tab and then reopening the DevTools Extensions tab, the dashboard page appears instead of the main landing page. Main privacy sandbox landing page to be visible across all tabs.

dashboard.webm

@pavanpatil1 This is expected behavior. We show the landing page only on the first use of the extension. After that, we display the dashboard regardless of whether users open it in the same or a different tab.

pavanpatil1 commented 1 month ago

Inside the wiki, the example analysis scenarios, page isn't loading correctly and displays an "error loading the page" message. Please note that this page contains diagrams.

Screenshot 2024-09-16 at 12 06 36 PM
fellyph commented 1 month ago

@mohdsayed the date can use DateTimeFormat to do the dates localization.

pavanpatil1 commented 1 month ago

In the Japanese translation, the "wiki" string does not display correctly. In other translations, such as Hindi and Korean, it appears as a single word, "Wiki."

Screenshot 2024-09-16 at 1 51 20 PM
pavanpatil1 commented 1 month ago

After downloading the report via the extension, the links in the "Known Breakages" section contain UTM parameters indicating "CLI," even though the report was obtained through the extension.

utm-parameter.webm

mohdsayed commented 1 month ago

The extra whitespace becomes visible on the wiki page when the page refresh notification is displayed.

Screenshot 2024-09-16 at 9 37 45 AM

@mayan-000 Looks like the same is happening on cookies landing page

image
pavanpatil1 commented 1 month ago

The block cookies are not visible in yellow background

CSV: psat-test.csv

Screenshot 2024-09-17 at 11 21 51 AM
fellyph commented 1 month ago

The known breakages section keeps loading in a loop when the multi-tab debugging switches off.

  1. navigate to natgeo.com
  2. analyze the page and check the known breakage report
  3. go to settings switch-off multi-tab debugging
  4. go back and re-analyze the page
  5. observe the known breakage report

https://github.com/user-attachments/assets/2b2c2f11-5872-4172-b627-e78e5a5ae2b4

fellyph commented 1 month ago

When the user clicks on the multi-tab debugging wiki page on the settings panel, the extension should scroll to multi-tab debugging section:

  1. go to the settings panel
  2. at multitab debugging, click on the multi-tab debugging link on the description
  3. the extension goes to the wiki settings page and stays on the top of the page

https://github.com/user-attachments/assets/7a8d0a9d-b189-4ebc-bfc5-416453890b27

mayan-000 commented 1 month ago

When the user clicks on the multi-tab debugging wiki page on the settings panel, the extension should scroll to multi-tab debugging section:

  1. go to the settings panel
  2. at multitab debugging, click on the multi-tab debugging link on the description
  3. the extension goes to the wiki settings page and stays on the top of the page

    2024-09-17.07-11-11.mov

@fellyph Wiki doesn't have an anchor tag to the heading, so navigation is not possible. - ref

fellyph commented 1 month ago

thanks @mayan-000 I will close this issue

mohdsayed commented 1 month ago

Inconsistent scrolling behavior on page switch between navigation menu items in wiki

Steps to replicate:

  1. Open the wiki in Privacy Sandbox panel.
  2. Navigate to any page, for example, "Known Breakages".
  3. Now, click on a different heading in the left navigation menu, for example, "Filtering". Observe: The page scrolls to the bottom first and then scrolls back up to the "Filtering" section.
  4. Now, click on "Known Breakages" again from the left navigation menu. Observe: This time, the page scrolls directly to the "Known Breakages" section without first going to the bottom of the page.

Screencast:

2024-09-12.16-51-23.Inconsistent.Scroll.issue.mp4

Expected Behavior:

Regardless of the user's previous scroll position or the page they were on, clicking on a navigation menu item should always result in the following consistent behavior:

  1. On a page change, start from the top of the page.
  2. Scroll to the clicked heading's position on the page.

@gagan0123 Not sure, why this is going below first when coming from a different page in hashes. Probably content like images are not loaded properly. Since this is not a major issue, we will try to fix in the next version.

gagan0123 commented 1 month ago

Most fixes have been implemented in v0.11.0. This issue will remain open to track any additional issues and pending items until they are migrated to separate GitHub issue/s.

pavanpatil1 commented 1 month ago

Most of the issues have been resolved and released as a part of v0.11.0. We will address the remaining issues in a separate ticket. Therefore, closing this issue.