search

GoogleChromeLabs / pywebsocket3

BSD 3-Clause "New" or "Revised" License
44 stars 32 forks source link

os.popen3 not present in Python 3 #17

Closed donny-dont closed 3 years ago

donny-dont commented 3 years ago

I'm currently working through running WebKit's Python infrastructure using Python 3 on Windows without Cygwin. The run-webkit-tests script starts up a web socket server from the web-platform-tests. It dies in wrap_popen3_for_win because os.popen3 is not defined in Python 3.

If overriding os.popen3 is required then a check should probably done as to whether its present in the os module.

ricea commented 3 years ago

Thanks! I will take a look.

ricea commented 3 years ago

Do you need the Cygwin support? I think the only reason we kept it was a rumour that WebKit was using it. If I remove the Cygwin support, then this gets much easier.

donny-dont commented 3 years ago

For our ports, WinCairo and PlayStation, we don't need cygwin support at all. Currently 🍎 is still using Cygwin in their AppleWin port. It would be nice if they stopped using it but I'll let one of them chime in.

@JonWBedard @gsnedders

gsnedders commented 3 years ago

Pretty sure we're unlikely to move away from Cygwin in the near future, at least. @JonWBedard would know better than me, though, and know more about longer term plans.

JonWBedard commented 3 years ago

We don't have a clear long-term plan for Windows at the moment, so the Cygwin status-quo will remain for at least the next year

donny-dont commented 3 years ago

Thanks @ricea !