GoogleChromeLabs / react-adaptive-hooks

Deliver experiences best suited to a user's device and network constraints
Apache License 2.0
5.1k stars 113 forks source link

[infra] allow react 17 as a peer dependency #62

Closed jdanil closed 2 years ago

jdanil commented 3 years ago

Bumping the react peer dependency for use with react 17. Tests are all passing. Don't believe anything changed with useEffect or useState in react 17.

google-cla[bot] commented 3 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹī¸ Googlers: Go here for more info.

jdanil commented 3 years ago

@googlebot I signed it!

jdanil commented 3 years ago

@addyosmani, sorry for the delay. Just signed the CLA when you have time to check this out.

chicio commented 2 years ago

Can we merge this improvement?

chicio commented 2 years ago

Someone can help/merge?

addyosmani commented 2 years ago

Thank you for the friendly ping here!

chicio commented 2 years ago

Thank you @addyosmani!!! 🙏

addyosmani commented 2 years ago

Sure! Are there any other PRs you would like to see landed before a release goes out? We're holding steady at ~5K downloads a week (awesome) but I do want to make sure folks aren't feeling blocked if there are important fixes or additions in the PR queue worth taking a look at.

chicio commented 2 years ago

At the moment this was the most important PR for me because in this way I can avoid to use the legacy peer deps flag with npm. Thank you again for your support 🙏

danieleloscozzese commented 2 years ago

This would be a valuable release in order to resolve the --legacy-peer-deps flag when installing with npm, as mentioned by @chicio. The upgrades in the PR queue look like in-range upgrades so far, I myself don't have any great request for another merge. A v0.0.9 including this peer dependency range expansion would be useful as-is.

adamhouten commented 1 year ago

Apologies for commenting on a year old PR, but did this change ever end up into a published version of the package? I've checked the npm page, and the latest version still seems to be v0.0.8.