GoogleChromeLabs / react-shrine

"Shrine" Progressive Web App sample built with React
https://react-shrine.web.app/
Apache License 2.0
331 stars 54 forks source link

Stable #15

Closed anton-karlovskiy closed 5 years ago

anton-karlovskiy commented 5 years ago

Rewrite the codebase based on react best practices

addyosmani commented 5 years ago

Can we check the UX for each route is the same as the current version? e.g

new image

vs current:

image

new image

vs old image

addyosmani commented 5 years ago

Fyi Landing.js has an import pointing to import './landing.css'; which should probably be import './Landing.css'; (fixed to get running locally)

addyosmani commented 5 years ago

Overall this is looking good so far. Could we sanity check that all async chunks / dynamic chunks are using webpack's magic comments so we can see their names while debugging?

image

anton-karlovskiy commented 5 years ago

Overall this is looking good so far. Could we sanity check that all async chunks / dynamic chunks are using webpack's magic comments so we can see their names while debugging?

image

I double checked all async/dynamic chunks. They are using webpack's magic comments for sure. Regarding those number names above, they are 3rd party libraries like react-magnifier etc which I think is not possible to name them.

anton-karlovskiy commented 5 years ago

Fyi Landing.js has an import pointing to import './landing.css'; which should probably be import './Landing.css'; (fixed to get running locally)

I fixed this by renaming from Landing.css to landing.css.