Closed anton-karlovskiy closed 5 years ago
Can we check the UX for each route is the same as the current version? e.g
new
vs current:
new
vs old
Fyi Landing.js
has an import pointing to import './landing.css';
which should probably be import './Landing.css';
(fixed to get running locally)
Overall this is looking good so far. Could we sanity check that all async chunks / dynamic chunks are using webpack's magic comments so we can see their names while debugging?
Overall this is looking good so far. Could we sanity check that all async chunks / dynamic chunks are using webpack's magic comments so we can see their names while debugging?
I double checked all async/dynamic chunks. They are using webpack's magic comments for sure. Regarding those number names above, they are 3rd party libraries like react-magnifier etc which I think is not possible to name them.
Fyi
Landing.js
has an import pointing toimport './landing.css';
which should probably beimport './Landing.css';
(fixed to get running locally)
I fixed this by renaming from Landing.css to landing.css.
Rewrite the codebase based on react best practices