search

GoogleChromeLabs / selenium-assistant

A node module that helps using browsers with selenium
https://googlechromelabs.github.io/selenium-assistant/
Apache License 2.0
90 stars 26 forks source link

Can't kill Safari #104

Closed robdodson closed 6 years ago

robdodson commented 6 years ago

Not sure if this is related to #45 but I noticed return seleniumAssistant.killWebDriver(driver); doesn't kill Safari. Works on Chrome and Firefox though :)

gauntface commented 6 years ago

I know I'm a little late to this. I'm hooking adding technology preview support for safari and it looks like I can set everything is closing as I'd expect apart from the safari app stays open in the dock - but the window actually closes.

Is that what you were experiencing?

robdodson commented 6 years ago

Can't recall now :P

Just tried with the latest and i'm seeing the same behavior you describe. Safari window closes, but the dock icon is still present. Not a huge deal IMO

robdodson commented 6 years ago

Sorry, didn't mean to close. I'll leave it up to you if you want this to remain open as a reminder or anything. Otherwise I'm cool if you close it.

gauntface commented 6 years ago

Ill close for now - but will likely dig into it more.