search

GoogleChromeLabs / selenium-assistant

A node module that helps using browsers with selenium
https://googlechromelabs.github.io/selenium-assistant/
Apache License 2.0
90 stars 26 forks source link

Can't kill Firefox 57 #105

Open robdodson opened 6 years ago

robdodson commented 6 years ago

It seems like the new FF doesn't get killed properly by seleniumAssistant.killWebDriver(driver);

gauntface commented 6 years ago

How did you get around this in your tests?

There is a very real chance that this was a discrepancy between selenium-webdriver and geckodriver :(

robdodson commented 6 years ago

How did you get around this in your tests?

I didn't. When I run the tests locally, Firefox remains open but the tests themselves run to completion so everything passes.

gauntface commented 6 years ago

I just published 5.3.0 could you give that a shot, if it's failing, then I'll clone and try it out on your repo and get it fixed.

robdodson commented 6 years ago

just tried with 5.3.0 but it remains open

robdodson commented 6 years ago

github.com/wicg/focus-visible if you wanna give it a shot