Firefox driver fails with error `timeouts`

GoogleChromeLabs / selenium-assistant

A node module that helps using browsers with selenium

Apache License 2.0

90 stars 26 forks source link

Open Minishlink opened 6 years ago

Minishlink commented 6 years ago

Using web-push-testing-service with selenium-assistant 5.3.0, Firefox throws an error timeouts. This seems to be linked to https://github.com/GoogleChromeLabs/selenium-assistant/commit/c1e84fd126d0863e39c140c6613c3eb64f86459c#diff-882c014a0d36e9a50465a88245164048R188. Removing this line seems to fix this problem, but it must have been added for a reason. Maybe we should upgrade selenium?

gauntface commented 6 years ago

@Minishlink Will dig into this later today - sorry for the inconvenience.

Minishlink commented 6 years ago

@gauntface Thanks! It's not a big problem for web-push-php at the moment anyway, but it could impact other people using Travis :)