GoogleChromeLabs / selenium-assistant

A node module that helps using browsers with selenium
https://googlechromelabs.github.io/selenium-assistant/
Apache License 2.0
90 stars 26 forks source link

Add temp fix for Safari 12+ #113

Closed philipwalton closed 5 years ago

philipwalton commented 5 years ago

When Safari 12 was released, we stopped being able to run tests against it due to this issue: https://github.com/SeleniumHQ/selenium/issues/6026

The PR conditionally puts Safari's webdriver into legacy mode when the version is 12 or greater.

Note: before adding this change, the Safari tests were failing, and after this change they pass for me. I'm not sure if any additional tests are needed beyond that.