search

GoogleChromeLabs / selenium-assistant

A node module that helps using browsers with selenium
https://googlechromelabs.github.io/selenium-assistant/
Apache License 2.0
90 stars 26 forks source link

Safari 13.1 fix #129

Closed jeffposnick closed 4 years ago

jeffposnick commented 4 years ago

R: @philipwalton CC: @gauntface (not sure how involved you want to be at this stage) C.f. https://github.com/GoogleChrome/workbox/pull/2444#issuecomment-612178752

This disables a workaround that was in place for Safari 12 compatibility. That workaround breaks things in Safari 13 (well, Safari 13.1 at least), so I changed the workaround logic so that it checks for a major version number of 12.

I also bumped up the selenium-webdriver dependency to ^4.0.0-alpha.7 from ^4.0.0-alpha.4.

I figure that this sort of thing warrants a minor semver change, so the package.json version was increased to 6.1.0.

jeffposnick commented 4 years ago

Also, the test suite seems to only be happy with node 10, so I'm adjusting the Travis CI config to force that version. From what I can tell, that's all due to devDependency requirements (some of which won't work with node 8, and some of which won't work with node 13).

I don't think the actual runtime node version requirements are any different, but it is harder to confirm that without a test suite that runs in those versions.