Closed aryanpingle closed 1 year ago
Hi @argyleink, do the changes look good to you? Before/After comparisons are in the description, and I've made the branch up-to-date with dev
:)
sorry for the delay here, I got super sick last week and was out for a few days. I'm ramping back up this week and have this on my todo list 👍🏻
@argyleink Ahh no worries at all, hope you're feeling better now 😄
@argyleink I added some new changes, would love to hear your thoughts :)
Keyboard accessibility is super important, and not just for the visually impaired. It's common practice to
TAB
through a website when your mouse is faulty and/or you can't be bothered to reach for it. The options components aren't very keyboard-accessible; this PR aims to change that.Changes include:
Visual Comparison
In both before and after I
TAB
to theAdvanced Settings
expander, and thenTAB
to the end. If it feels like I'm not doing anything in the before changes video... well, that's the issue. I also try to make the checkboxes feel like Material UI, but I can only get so far without a complete overhaul.Before changes - Little to no focus effects After changes - 100% support for keyboard navigation