search

GoogleChromeLabs / svgomg-twa

A sample that project Trusted Web Activities technology to wrap SVGOMG in an Android Application
Apache License 2.0
519 stars 132 forks source link

Use multi-line string for asset statements #54

Closed rayankans closed 4 years ago

rayankans commented 4 years ago

It just makes the thing more readable.

PEConn commented 4 years ago

I'm surprised that this works, but with Andre's LGTM I'm happy with it.

rayankans commented 4 years ago

To be clear, I tried this and it works.

andreban commented 4 years ago

That's Groovy's multi-line String (https://groovy-lang.org/syntax.html). This should indeed work.

nit: Adding a \ at the end of the first line will remove the new line introduced at the beginning of the string. The new line shouldn't be issue, but it sounds like removing it is a good idea?

rayankans commented 4 years ago

I tried adding the \, but the generated resources are the same. The newline was already ignored it seems. I don't think the change is necessary