GoogleChromeLabs / sw-appcache-behavior

A service worker implementation of the behavior defined in a page's AppCache manifest.
Apache License 2.0
54 stars 15 forks source link

callback for when new cache is ready #13

Closed mfulton26 closed 4 years ago

mfulton26 commented 4 years ago

From what I can tell every time I call init({ cachePopulatedCallback }) the cachePopulatedCallback is invoked even if the cache wasn't changed.

I'm not sure yet if this is an issue with initialization or if that callback was intended to always be called even if the same cache is in use.

jeffposnick commented 4 years ago

What URLs are passed to the cachePopulatedCallback function?

Do you see corresponding requests for those URLs in the Network panel in DevTools?

mfulton26 commented 4 years ago

I figured this out, it was a bug in the app I'm using this in around calling reload constantly 😄

from what I can tell this is working great; thank you

jeffposnick commented 4 years ago

Great to hear!