GoogleChromeLabs / sw-precache

[Deprecated] A node module to generate service worker code that will precache specific resources so they work offline.
https://developers.google.com/web/tools/workbox/guides/migrations/migrate-from-sw
Apache License 2.0
5.22k stars 388 forks source link

Clarify cache check in navigateFallback #301

Closed mlcdf closed 7 years ago

mlcdf commented 7 years ago

Fixes #204

Ugh, I just noticed I've also removed trailing whitespaces although I didn't mean to. Does this bother you?

googlebot commented 7 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


mlcdf commented 7 years ago

I signed it!

googlebot commented 7 years ago

CLAs look good, thanks!

jeffposnick commented 7 years ago

Thanks!