GoogleChromeLabs / sw-precache

[Deprecated] A node module to generate service worker code that will precache specific resources so they work offline.
https://developers.google.com/web/tools/workbox/guides/migrations/migrate-from-sw
Apache License 2.0
5.22k stars 388 forks source link

handleFetch not working #350

Open redixhumayun opened 6 years ago

redixhumayun commented 6 years ago

My sw-precache-config file is listed as below

module.exports = {
    staticFileGlobs: [
        'build/**.png',
        'build/vega-icons/**', 
        'build/static/**'
    ],
    swFilePath: './build/service-worker.js', 
    templateFilePath: './service-worker.tmpl', 
    stripPrefix: 'build/', 
    handleFetch: false
}

I am using the template file provided in the src code locally.

Even with the handleFetch flag set to false, I am still seeing the fetch event listener being added to the output service worker.

mbj36 commented 6 years ago

Can you try removing the output service worker and then regenerate ?

mbj36 commented 6 years ago

By the way, if you are starting out, then you should try Workbox

redixhumayun commented 6 years ago

@mbj36 - The reason I am choosing the sw-precache over Workbox is because I am using service workers with the CRA build. I believe that is configured using sw-precache?

redixhumayun commented 6 years ago

@mbj36 - By removing the output service worker, I assume you mean remove the swFilePath from the config file? If so, no that does not work. I get the same output as before.

dfranusic commented 6 years ago

I am facing the same issue. I have just started with CRA and PWA and sw-preache (as @redixhumayun stated) is the best option to customize CRA auto generated service worker.

ray007 commented 5 years ago

By the way, if you are starting out, then you should try Workbox

I really hope this project will continue. Workbox is a kitchen-sink with everything in it, sw-precache creates a self-contained script of 11kB before minimizing for me.